[Internal] Update Jobs GetRun API to support paginated responses for jobs and ForEach tasks #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkiko10
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
requested changes
Nov 12, 2024
Contributor
renaudhartert-db
left a comment
renaudhartert-db
left a comment
There was a problem hiding this comment.
Could you undo the changes in WorkspaceClient.java? These will be done automatically once we have updated the code generation template.
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
gkiko10
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Test Details: go/deco-tests/11859553955 |
renaudhartert-db
approved these changes
Nov 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
### Internal Changes * Update Jobs GetRun API to support paginated responses for jobs and ForEach tasks ([#386](#386)). ### API Changes: * Added `servicePrincipalClientId` field for `com.databricks.sdk.service.apps.App`. * Added `azureServicePrincipal`, `gcpServiceAccountKey` and `readOnly` fields for `com.databricks.sdk.service.catalog.CreateCredentialRequest`. * Added `azureServicePrincipal`, `readOnly` and `usedForManagedStorage` fields for `com.databricks.sdk.service.catalog.CredentialInfo`. * Added `azureServicePrincipal` and `readOnly` fields for `com.databricks.sdk.service.catalog.UpdateCredentialRequest`. * Added `externalLocationName`, `readOnly` and `url` fields for `com.databricks.sdk.service.catalog.ValidateCredentialRequest`. * Added `isDir` field for `com.databricks.sdk.service.catalog.ValidateCredentialResponse`. * Changed `createCredential()` and `generateTemporaryServiceCredential()` methods for `workspaceClient.credentials()` service with new required argument order. * Changed `accessConnectorId` field for `com.databricks.sdk.service.catalog.AzureManagedIdentity` to be required. * Changed `accessConnectorId` field for `com.databricks.sdk.service.catalog.AzureManagedIdentity` to be required. * Changed `name` field for `com.databricks.sdk.service.catalog.CreateCredentialRequest` to be required. * Changed `credentialName` field for `com.databricks.sdk.service.catalog.GenerateTemporaryServiceCredentialRequest` to be required. OpenAPI SHA: f2385add116e3716c8a90a0b68e204deb40f996c, Date: 2024-11-15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Introduces extension for jobs getRun call that paginates tasks and iterations arrays in the response and returns aggregated response to the caller. This change is necessary to prepare for jobs API 2.2 release that serves paginated response. Pagination is over once the next_page_token is absent from the response. The pagination logic is not exposed to the customer.
How is this tested?
Unit tests